From 75ce9158a3764707d8a6b0c0445c64e9b90b3126 Mon Sep 17 00:00:00 2001 From: liaozan <378024053@qq.com> Date: Mon, 18 Sep 2023 20:26:00 +0800 Subject: [PATCH] Generate toString method with callSuper=true --- .../schbrain/common/exception/BaseException.java | 2 +- .../exception/DefaultGlobalExceptionResolver.java | 5 +++-- .../ExceptionHandingWebMvcConfigurer.java | 7 ++++--- .../autoconfigure/oss/bean/CopyResult.java | 4 ++-- .../autoconfigure/oss/bean/DeleteResult.java | 4 ++-- .../autoconfigure/oss/bean/DownloadResult.java | 6 +++--- .../autoconfigure/oss/bean/UploadCredentials.java | 13 +++++-------- .../autoconfigure/oss/bean/UploadResult.java | 6 +++--- .../autoconfigure/oss/util/OssUtils.java | 15 ++++++++++----- 9 files changed, 33 insertions(+), 29 deletions(-) diff --git a/commons/common/src/main/java/com/schbrain/common/exception/BaseException.java b/commons/common/src/main/java/com/schbrain/common/exception/BaseException.java index 6a7bb59..6262bc6 100644 --- a/commons/common/src/main/java/com/schbrain/common/exception/BaseException.java +++ b/commons/common/src/main/java/com/schbrain/common/exception/BaseException.java @@ -38,4 +38,4 @@ public class BaseException extends RuntimeException { this.action = action; } -} \ No newline at end of file +} diff --git a/commons/web-common/src/main/java/com/schbrain/common/web/exception/DefaultGlobalExceptionResolver.java b/commons/web-common/src/main/java/com/schbrain/common/web/exception/DefaultGlobalExceptionResolver.java index ef6172b..8e7bcbb 100644 --- a/commons/web-common/src/main/java/com/schbrain/common/web/exception/DefaultGlobalExceptionResolver.java +++ b/commons/web-common/src/main/java/com/schbrain/common/web/exception/DefaultGlobalExceptionResolver.java @@ -1,7 +1,6 @@ package com.schbrain.common.web.exception; import com.schbrain.common.web.annotation.ResponseWrapOption; -import lombok.EqualsAndHashCode; import lombok.extern.slf4j.Slf4j; import org.springframework.web.context.request.ServletWebRequest; import org.springframework.web.method.HandlerMethod; @@ -30,7 +29,6 @@ import static com.schbrain.common.web.utils.HandlerMethodAnnotationUtils.getAnno * @since 2022/8/30 */ @Slf4j -@EqualsAndHashCode(callSuper = true) public class DefaultGlobalExceptionResolver extends AbstractHandlerMethodExceptionResolver { private final GlobalExceptionHandler exceptionHandler; @@ -49,6 +47,9 @@ public class DefaultGlobalExceptionResolver extends AbstractHandlerMethodExcepti @Override protected boolean shouldApplyTo(HttpServletRequest request, @Nullable Object handler) { + if (handler == null) { + return super.shouldApplyTo(request, null); + } if (handler instanceof HandlerMethod) { HandlerMethod handlerMethod = (HandlerMethod) handler; ResponseWrapOption responseWrapOption = getAnnotation(handlerMethod, ResponseWrapOption.class); diff --git a/commons/web-common/src/main/java/com/schbrain/common/web/exception/ExceptionHandingWebMvcConfigurer.java b/commons/web-common/src/main/java/com/schbrain/common/web/exception/ExceptionHandingWebMvcConfigurer.java index dac2743..bd8eccd 100644 --- a/commons/web-common/src/main/java/com/schbrain/common/web/exception/ExceptionHandingWebMvcConfigurer.java +++ b/commons/web-common/src/main/java/com/schbrain/common/web/exception/ExceptionHandingWebMvcConfigurer.java @@ -39,12 +39,13 @@ public class ExceptionHandingWebMvcConfigurer implements WebMvcConfigurer { } } + int index; if (adviceExceptionResolver == null) { - log.warn("ExceptionHandlerExceptionResolver is not exist, ignore global exception handing"); - return; + index = 0; + } else { + index = resolvers.indexOf(adviceExceptionResolver) + 1; } - int index = resolvers.indexOf(adviceExceptionResolver) + 1; resolvers.add(index, createExceptionResolver(adviceExceptionResolver)); } diff --git a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/CopyResult.java b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/CopyResult.java index 70649dd..38c444e 100644 --- a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/CopyResult.java +++ b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/CopyResult.java @@ -2,17 +2,17 @@ package com.schbrain.framework.autoconfigure.oss.bean; import lombok.Data; import lombok.EqualsAndHashCode; +import lombok.ToString; /** * @author lik * @since 2022/9/6 */ @Data +@ToString(callSuper = true) @EqualsAndHashCode(callSuper = true) public class CopyResult extends OssOperationResult { - private static final long serialVersionUID = 7322484488471640978L; - private String destinationKey; private String destinationBucket; diff --git a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DeleteResult.java b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DeleteResult.java index 1c0cf60..751a722 100644 --- a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DeleteResult.java +++ b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DeleteResult.java @@ -2,6 +2,7 @@ package com.schbrain.framework.autoconfigure.oss.bean; import lombok.Data; import lombok.EqualsAndHashCode; +import lombok.ToString; import java.util.List; @@ -10,11 +11,10 @@ import java.util.List; * @since 2022/9/6 */ @Data +@ToString(callSuper = true) @EqualsAndHashCode(callSuper = true) public class DeleteResult extends OssOperationResult { - private static final long serialVersionUID = -1964404722922995469L; - private List deleteObjectKeys; public static DeleteResult success(String bucket, List objectKeys) { diff --git a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DownloadResult.java b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DownloadResult.java index 7404574..dadc63e 100644 --- a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DownloadResult.java +++ b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/DownloadResult.java @@ -3,17 +3,17 @@ package com.schbrain.framework.autoconfigure.oss.bean; import com.aliyun.oss.model.OSSObject; import lombok.Data; import lombok.EqualsAndHashCode; +import lombok.ToString; /** * @author liaozan * @since 2021/12/3 */ @Data +@ToString(callSuper = true) @EqualsAndHashCode(callSuper = true) public class DownloadResult extends OssOperationResult { - private static final long serialVersionUID = -9010079317621184645L; - private OSSObject ossObject; public static DownloadResult success(String bucket, String objectKey, OSSObject ossObject) { @@ -34,4 +34,4 @@ public class DownloadResult extends OssOperationResult { return result; } -} \ No newline at end of file +} diff --git a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadCredentials.java b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadCredentials.java index 7544064..0c7fa50 100644 --- a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadCredentials.java +++ b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadCredentials.java @@ -3,6 +3,8 @@ package com.schbrain.framework.autoconfigure.oss.bean; import com.aliyuncs.auth.sts.AssumeRoleResponse.Credentials; import lombok.Data; import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; +import lombok.ToString; import java.time.LocalDateTime; import java.time.ZoneId; @@ -14,11 +16,11 @@ import java.time.format.DateTimeFormatter; * @since 2021/12/4 */ @Data +@NoArgsConstructor +@ToString(callSuper = true) @EqualsAndHashCode(callSuper = true) public class UploadCredentials extends OssOperationResult { - private static final long serialVersionUID = 5546792221041679671L; - private String accessKeyId; private String accessKeySecret; @@ -27,11 +29,6 @@ public class UploadCredentials extends OssOperationResult { private LocalDateTime expiration; - // for json deserialize - public UploadCredentials() { - - } - public UploadCredentials(Credentials credentials) { this.success = true; this.accessKeyId = credentials.getAccessKeyId(); @@ -49,4 +46,4 @@ public class UploadCredentials extends OssOperationResult { this.errorMsg = errorMsg; } -} \ No newline at end of file +} diff --git a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadResult.java b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadResult.java index 75c5e52..a4083cd 100644 --- a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadResult.java +++ b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/bean/UploadResult.java @@ -2,17 +2,17 @@ package com.schbrain.framework.autoconfigure.oss.bean; import lombok.Data; import lombok.EqualsAndHashCode; +import lombok.ToString; /** * @author liaozan * @since 2021/12/3 */ @Data +@ToString(callSuper = true) @EqualsAndHashCode(callSuper = true) public class UploadResult extends OssOperationResult { - private static final long serialVersionUID = 7408490108665799098L; - private String url; public static UploadResult success(String bucket, String objectKey, String url) { @@ -33,4 +33,4 @@ public class UploadResult extends OssOperationResult { return result; } -} \ No newline at end of file +} diff --git a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/util/OssUtils.java b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/util/OssUtils.java index 244efb8..3f4d980 100644 --- a/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/util/OssUtils.java +++ b/starters/oss-spring-boot-starter/src/main/java/com/schbrain/framework/autoconfigure/oss/util/OssUtils.java @@ -16,6 +16,7 @@ import com.aliyuncs.http.MethodType; import com.aliyuncs.profile.DefaultProfile; import com.aliyuncs.profile.IClientProfile; import com.schbrain.common.util.ApplicationName; +import com.schbrain.common.util.StreamUtils; import com.schbrain.common.util.ValidateUtils; import com.schbrain.framework.autoconfigure.oss.bean.*; import com.schbrain.framework.autoconfigure.oss.exception.OssException; @@ -23,6 +24,7 @@ import com.schbrain.framework.autoconfigure.oss.properties.OssProperties; import com.schbrain.framework.autoconfigure.oss.properties.OssProperties.StsProperties; import lombok.Getter; import lombok.extern.slf4j.Slf4j; +import org.apache.commons.collections4.CollectionUtils; import org.apache.commons.lang3.StringUtils; import java.io.File; @@ -33,7 +35,6 @@ import java.time.*; import java.time.format.DateTimeFormatter; import java.util.Date; import java.util.List; -import java.util.stream.Collectors; /** * @author liaozan @@ -265,8 +266,8 @@ public class OssUtils { public static DeleteResult deleteObject(String bucket, List objectKeys) { ValidateUtils.notEmpty(bucket, "bucket can not be empty"); ValidateUtils.notEmpty(objectKeys, "objectKeys can not be empty"); - String notExistKeys = objectKeys.stream().filter(key -> !exist(bucket, key)).collect(Collectors.joining(",")); - if (StringUtils.isNotBlank(notExistKeys)) { + List notExistKeys = StreamUtils.filterToList(objectKeys, key -> !exist(bucket, key)); + if (CollectionUtils.isNotEmpty(notExistKeys)) { String errorMsg = StrFormatter.format("objectKeys:[{}] not exist", notExistKeys); return DeleteResult.fail(bucket, objectKeys, errorMsg); } @@ -286,8 +287,12 @@ public class OssUtils { private static DownloadResult download0(String bucket, String objectKey) { GetObjectRequest request = new GetObjectRequest(bucket, objectKey); - OSSObject ossObject = getOssClient().getObject(request); - return DownloadResult.success(bucket, objectKey, ossObject); + try { + OSSObject ossObject = getOssClient().getObject(request); + return DownloadResult.success(bucket, objectKey, ossObject); + } catch (Exception e) { + return DownloadResult.fail(bucket, objectKey, e.getMessage()); + } } private static UploadResult upload0(Object object, String bucket, String objectKey, boolean allowOverwrite, boolean appendPrefix, ObjectMetadata metadata) { -- GitLab